Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare yarn berry just once #7160

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

I think the problem was not that native helpers pull Yarn 1, but that the version was being activated for the root user, not for the dependabot user. I don't think we need it for root.

(Extracted from #7134)

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and thanks for extracting this out.

I think the problem was not that native helpers pull Yarn 1, but that
the version was being activated for the root user, not for the
dependabot user. I don't think we need it for root.
@jeffwidman jeffwidman force-pushed the deivid-rodriguez/remove-unnecesary-corepack-command branch from b4042cc to d95cd0f Compare April 25, 2023 05:35
@jeffwidman jeffwidman enabled auto-merge (squash) April 25, 2023 05:35
@jeffwidman jeffwidman enabled auto-merge (squash) April 25, 2023 05:35
@jeffwidman jeffwidman merged commit 89c7646 into main Apr 25, 2023
@jeffwidman jeffwidman deleted the deivid-rodriguez/remove-unnecesary-corepack-command branch April 25, 2023 05:45
@abdulapopoola abdulapopoola added the EE Engineering Efficiency label Apr 26, 2023
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
I think the problem was not that native helpers pull Yarn 1, but that
the version was being activated for the root user, not for the
dependabot user. I don't think we need it for root.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EE Engineering Efficiency L: javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants